Bug 147218

Summary: Simplify DFG::DesiredIdentifiers and make it possible to turn a UniquedStringImpl* into an identifierNumber at any time
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 146929    
Attachments:
Description Flags
the patch sam: review+

Description Filip Pizlo 2015-07-22 20:01:25 PDT 
In trunk, the DFG::ByteCodeParser can turn UniquedStringImpl*'s into identifierNumbers when it parses a new CodeBlock, but it cannot easily do it at any other time.  But it's trivial to just put that functionality inside DFG::DesiredIdentifiers, which will enable any phase (including ByteCodeParser) to turn a UniquedStringImpl* into an identifierNumber at any time.
Comment 1 Filip Pizlo 2015-07-22 20:07:22 PDT 
Created attachment 257331 [details]
the patch
Comment 2 Filip Pizlo 2015-07-22 22:00:19 PDT 
Landed in http://trac.webkit.org/changeset/187214