Bug 147218

Summary: Simplify DFG::DesiredIdentifiers and make it possible to turn a UniquedStringImpl* into an identifierNumber at any time
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 146929    
Attachments:
Description Flags
the patch sam: review+

Filip Pizlo
Reported 2015-07-22 20:01:25 PDT
In trunk, the DFG::ByteCodeParser can turn UniquedStringImpl*'s into identifierNumbers when it parses a new CodeBlock, but it cannot easily do it at any other time. But it's trivial to just put that functionality inside DFG::DesiredIdentifiers, which will enable any phase (including ByteCodeParser) to turn a UniquedStringImpl* into an identifierNumber at any time.
Attachments
the patch (8.07 KB, patch)
2015-07-22 20:07 PDT, Filip Pizlo 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-07-22 20:07:22 PDT
Created attachment 257331 [details] the patch
Filip Pizlo
Comment 2 2015-07-22 22:00:19 PDT
Landed in http://trac.webkit.org/changeset/187214
Note You need to log in before you can comment on or make changes to this bug.