Bug 147204

Summary: Web Inspector: Timeline's Current Time does not jump forward to new start time when starting a new recording, causes timeline to appear delayed and broken
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, simon.fraser, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-07-22 15:17:57 PDT 
* SUMMARY
Timeline's Current Time does not jump forward to new start time when starting a new recording, causes timeline to appear delayed and broken.

* STEPS TO REPRODUCE
1. Inspect https://en.wikipedia.org/wiki/Main_Page
2. Show timelines tab
3. Command-R to reload
4. Timeline starts automatically
5. Wait for timeline to stop or manually stop at about the 5s mark.
6. Wait 30 seconds
7. Click button to start recording
8. Scroll page a bit to ensure we have events.
9. Click button to stop recording
  => Timeline plays nothing for 30 seconds and the shows events for the 1s of recording
  => Expected timeline to immediately jump forward 30s and show the events for the 1s of recording
Comment 1 Joseph Pecoraro 2015-07-22 15:18:30 PDT 
<rdar://problem/21946519>
Comment 2 Joseph Pecoraro 2015-07-22 15:21:15 PDT 
Created attachment 257300 [details]
[PATCH] Proposed Fix
Comment 3 Matt Baker 2015-07-22 15:50:52 PDT 
Comment on attachment 257300 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257300&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:-520
> -

Child records of the rendering frame are added to the other timelines, so this change would potentially net us an earlier current time, but the difference should be very small.
Comment 4 Matt Baker 2015-07-22 16:07:30 PDT 
Comment on attachment 257300 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=257300&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:-517
> -            // The rendering frame timeline doesn't use a time axis.

The axis type is irrelevant. A rendering frame record generally has an earlier start time than its first child, which we want to account for. We should remove this check.
Comment 5 WebKit Commit Bot 2015-07-22 21:19:58 PDT 
Comment on attachment 257300 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 257300

Committed r187209: <http://trac.webkit.org/changeset/187209>
Comment 6 WebKit Commit Bot 2015-07-22 21:20:01 PDT 
All reviewed patches have been landed.  Closing bug.