Bug 147191

Summary: [EFL] The "Missing Plug-in" buttons are not showing up on some flash contents
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebKit EFLAssignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
a test content taken from http://www.youku.com/
none
Patch none

Description Sungmann Cho 2015-07-22 07:57:09 PDT 
Created attachment 257268 [details]
a test content taken from http://www.youku.com/

Currently, WebKitEFL doesn't show the "Missing Plug-in" buttons if the plugin-related tags don't have a "type" attribute.
In such a case, WebCore tries to guess the MIME type from the extensions by using MIMETypeRegistry::getMIMETypeForExtension().
For WebKitEFL, MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple array of
<extension, mime type>, looking for the mime type for the given extension. But |extensionMap| in MIMETypeRegistryEfl.cpp
doesn't have the information for ".swf", so WebCore fails to guess the MIME type and regard the content type as
ObjectContentFrame, not ObjectContentNetscapePlugin.
Comment 1 Sungmann Cho 2015-07-22 08:00:49 PDT 
Created attachment 257269 [details]
Patch
Comment 2 Sungmann Cho 2015-07-22 08:11:38 PDT 
WebKitGTK+ also had the same problem and the issue has now been resolved.
http://trac.webkit.org/changeset/186581
Comment 3 Gyuyoung Kim 2015-07-22 17:28:24 PDT 
Comment on attachment 257269 [details]
Patch

nice fix. r=me.
Comment 4 WebKit Commit Bot 2015-07-22 20:37:51 PDT 
Comment on attachment 257269 [details]
Patch

Clearing flags on attachment: 257269

Committed r187206: <http://trac.webkit.org/changeset/187206>
Comment 5 WebKit Commit Bot 2015-07-22 20:37:53 PDT 
All reviewed patches have been landed.  Closing bug.