Bug 147190

Summary: [l10n] Updated Swedish translation
Product: WebKit Reporter: josef.andersson
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Enhancement CC: berto, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Updated Swedish translation
none
Patch
none
Patch commit-queue: commit-queue-

Description josef.andersson 2015-07-22 07:13:29 PDT
Created attachment 257264 [details]
Updated Swedish translation

A fellow translator did a review and found some minor errors in the translation which are now corrected - please commit attached file.
Comment 1 Michael Catanzaro 2015-07-22 07:45:09 PDT
Created attachment 257265 [details]
Patch
Comment 2 WebKit Commit Bot 2015-07-22 07:47:22 PDT
Comment on attachment 257265 [details]
Patch

Rejecting attachment 257265 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 257265, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/platform/gtk/po/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6675043559931904
Comment 3 Michael Catanzaro 2015-07-22 07:50:01 PDT
Created attachment 257266 [details]
Patch
Comment 4 Michael Catanzaro 2015-07-22 07:51:15 PDT
Thanks for keeping the translation up to date!
Comment 5 WebKit Commit Bot 2015-07-22 07:52:30 PDT
Comment on attachment 257266 [details]
Patch

Rejecting attachment 257266 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 257266, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Michael Catanzaro found in /Volumes/Data/EWS/WebKit/Source/WebCore/platform/gtk/po/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/Source/WebCore/platform/gtk/po/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/6340152074960896
Comment 6 Michael Catanzaro 2015-07-22 07:59:12 PDT
Committed r187157: <http://trac.webkit.org/changeset/187157>
Comment 7 Michael Catanzaro 2015-07-22 08:00:00 PDT
mrobinson:  mcatanzaro: I think you just need to change the ChangeLog line to Unreviewed.
mcatanzaro:  mrobinson: I am resisting due to the fact that it was reviewed by an actual Swedish-speaking person. :p
mrobinson:  mcatanzaro: You speak Swedish?
mcatanzaro:  mrobinson: "A fellow translator did a review and found some minor errors in the translation which are now corrected"
mrobinson:  Ah.
mcatanzaro:  I will just not use commit queue
mcatanzaro:  Translations are special
mrobinson:  mcatanzaro: I think it might mess up to the tools to have you in the reviewer field without you having the review bit.
mrobinson:  But whatevs. :)
mcatanzaro:  mrobinson: I thought the rubber-stamp line would work but apparently not.
mcatanzaro:  mrobinson: I will simply remove the line; we don't need it for commits that only touch translations.
mrobinson:  mcatanzaro: I think it's just an alias for "Reviewed"
mcatanzaro:  Apparently yes