Summary: | 1-5% regression in JavaScript performance | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> | ||||||
Component: | JavaScriptCore | Assignee: | Maciej Stachowiak <mjs> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | zwarich | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 523.x (Safari 3) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Maciej Stachowiak
2007-07-22 22:32:47 PDT
Created attachment 15643 [details]
patch that actually makes it faster than pre-regression
Comment on attachment 15643 [details]
patch that actually makes it faster than pre-regression
r=me, with the comments from IRC
Removing the jsString() is in contradiction with section 12.2 of the ECMA spec, which says that variable statements return the name of the identifier as a string. Not that I think this is a sane choice or even useful in a single case, but it's why I copied it in from the other code. I recently noticed that even with the jsString() there now it won't return the string value if you do something like: function f() { var x = 1; } alert(f()); It's worth noting that neither Firefox nor Opera return the string. Created attachment 15645 [details]
oops, caused some test regressions; fix
|