| Summary: | Animated images should animate in previews | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bdakin, mitz, thorton, yongjun_zhang | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Beth Dakin
2015-07-21 16:38:57 PDT
Created attachment 257219 [details]
Patch
Comment on attachment 257219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257219&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69 > +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); This (and some of the earlier-added) NSArray * argument should be a WK_ARRAY() of the appropriate type. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288 > + RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()]; Why get the actions and change _previewType outside the below if? (In reply to comment #2) > Comment on attachment 257219 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257219&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69 > > +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); > > This (and some of the earlier-added) NSArray * argument should be a > WK_ARRAY() of the appropriate type. > Fixed this and the earlier-added arguments! > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288 > > + RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()]; > > Why get the actions and change _previewType outside the below if? No good reason! Fixed. Thanks Dan! |