Bug 147173

Summary: Animated images should animate in previews
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, mitz, thorton, yongjun_zhang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Beth Dakin
Reported 2015-07-21 16:38:57 PDT
Animated images should animate in previews rdar://problem/21637698
Attachments
Patch (9.36 KB, patch)
2015-07-21 17:04 PDT, Beth Dakin 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2015-07-21 17:04:55 PDT
Created attachment 257219 [details] Patch
mitz
Comment 2 2015-07-21 17:14:48 PDT
Comment on attachment 257219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257219&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69 > +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); This (and some of the earlier-added) NSArray * argument should be a WK_ARRAY() of the appropriate type. > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288 > + RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()]; Why get the actions and change _previewType outside the below if?
Beth Dakin
Comment 3 2015-07-22 11:46:05 PDT
(In reply to comment #2) > Comment on attachment 257219 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=257219&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:69 > > +- (UIViewController *)_webView:(WKWebView *)webView previewViewControllerForAnimatedImageAtURL:(NSURL *)url defaultActions:(NSArray *)actions elementInfo:(_WKActivatedElementInfo *)elementInfo imageSize:(CGSize)imageSize WK_AVAILABLE(WK_MAC_TBA, WK_IOS_TBA); > > This (and some of the earlier-added) NSArray * argument should be a > WK_ARRAY() of the appropriate type. > Fixed this and the earlier-added arguments! > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3288 > > + RetainPtr<NSArray> actions = [_actionSheetAssistant defaultActionsForImageSheet:elementInfo.get()]; > > Why get the actions and change _previewType outside the below if? No good reason! Fixed. Thanks Dan!
Beth Dakin
Comment 4 2015-07-22 12:17:00 PDT
http://trac.webkit.org/changeset/187173
Note You need to log in before you can comment on or make changes to this bug.