Bug 147152

Summary: [iOS] Avoid using a TextIndicator if there are non-text things to indicate
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, enrica, hyatt, sam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Tim Horton 2015-07-21 09:46:19 PDT 
[iOS] Avoid using a TextIndicator if there are non-text things to indicate
Comment 1 Tim Horton 2015-07-21 09:46:53 PDT 
Created attachment 257184 [details]
Patch
Comment 2 Beth Dakin 2015-07-21 10:41:20 PDT 
Comment on attachment 257184 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257184&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2215
> +                            const float marginInPoints = 4;

It's unfortunate to have this constant in two places. Maybe it can be declared in one spot for use in both?
Comment 3 Tim Horton 2015-07-21 10:42:52 PDT 
(In reply to comment #2)
> Comment on attachment 257184 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257184&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2215
> > +                            const float marginInPoints = 4;
> 
> It's unfortunate to have this constant in two places. Maybe it can be
> declared in one spot for use in both?

Ideally yes, but where!
Comment 4 WebKit Commit Bot 2015-07-21 12:59:21 PDT 
Comment on attachment 257184 [details]
Patch

Clearing flags on attachment: 257184

Committed r187117: <http://trac.webkit.org/changeset/187117>
Comment 5 WebKit Commit Bot 2015-07-21 12:59:25 PDT 
All reviewed patches have been landed.  Closing bug.