Bug 147144

Summary: StyleSheetContents::wrapperInsertRule() can create rules that overflow RuleData's selector index
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Patch achristensen: review+

Description Benjamin Poulain 2015-07-21 00:28:16 PDT
StyleSheetContents::wrapperInsertRule() can create rules that overflow RuleData's selector index
Comment 1 Benjamin Poulain 2015-07-21 01:12:07 PDT
Created attachment 257170 [details]
Patch
Comment 2 Benjamin Poulain 2015-07-21 01:15:47 PDT
Created attachment 257172 [details]
Patch
Comment 3 Build Bot 2015-07-21 01:36:02 PDT
Comment on attachment 257172 [details]
Patch

Attachment 257172 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5201697978712064

New failing tests:
fast/media/mq-pixel-ratio-print.html
fast/dom/css-delete-doc.html
fast/css/insertRule-media.html
fast/dom/StyleSheet/gc-parent-rule.html
animations/keyframes-dynamic.html
Comment 4 Build Bot 2015-07-21 01:36:05 PDT
Created attachment 257174 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Benjamin Poulain 2015-07-21 01:44:13 PDT
Created attachment 257175 [details]
Patch
Comment 6 Radar WebKit Bug Importer 2015-07-21 07:40:40 PDT
<rdar://problem/21919408>
Comment 7 Alex Christensen 2015-07-21 11:09:34 PDT
Comment on attachment 257175 [details]
Patch

r=me, I would add a test with 8193 selectors that succeeds.
Comment 8 Benjamin Poulain 2015-07-21 16:18:20 PDT
Committed r187133: <http://trac.webkit.org/changeset/187133>