Bug 147144

Summary: StyleSheetContents::wrapperInsertRule() can create rules that overflow RuleData's selector index
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews103 for mac-mavericks
none
Patch achristensen: review+

Benjamin Poulain
Reported 2015-07-21 00:28:16 PDT
StyleSheetContents::wrapperInsertRule() can create rules that overflow RuleData's selector index
Attachments
Patch (491.29 KB, patch)
2015-07-21 01:12 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (490.72 KB, patch)
2015-07-21 01:15 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-mavericks (776.81 KB, application/zip)
2015-07-21 01:36 PDT, Build Bot 		no flags
Details
Patch (490.75 KB, patch)
2015-07-21 01:44 PDT, Benjamin Poulain 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2015-07-21 01:12:07 PDT
Created attachment 257170 [details] Patch
Benjamin Poulain
Comment 2 2015-07-21 01:15:47 PDT
Created attachment 257172 [details] Patch
Build Bot
Comment 3 2015-07-21 01:36:02 PDT
Comment on attachment 257172 [details] Patch Attachment 257172 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5201697978712064 New failing tests: fast/media/mq-pixel-ratio-print.html fast/dom/css-delete-doc.html fast/css/insertRule-media.html fast/dom/StyleSheet/gc-parent-rule.html animations/keyframes-dynamic.html
Build Bot
Comment 4 2015-07-21 01:36:05 PDT
Created attachment 257174 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Benjamin Poulain
Comment 5 2015-07-21 01:44:13 PDT
Created attachment 257175 [details] Patch
Radar WebKit Bug Importer
Comment 6 2015-07-21 07:40:40 PDT
<rdar://problem/21919408>
Alex Christensen
Comment 7 2015-07-21 11:09:34 PDT
Comment on attachment 257175 [details] Patch r=me, I would add a test with 8193 selectors that succeeds.
Benjamin Poulain
Comment 8 2015-07-21 16:18:20 PDT
Committed r187133: <http://trac.webkit.org/changeset/187133>
Note You need to log in before you can comment on or make changes to this bug.