Bug 147112

Summary:

WTFCrash() in WebKit::WebProcess::networkConnection()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

WebKit2

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, andersca, ap, barraclough, beidson, benjamin, cmarcelo, commit-queue, ddkilzer, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

iPhone / iPad

OS:

iOS 8.2

Attachments:

Description	Flags
Patch	none
Patch	none

Description Daniel Bates 2015-07-20 10:52:49 PDT

<rdar://problem/18477459>

Thread 0 name:  Dispatch queue: com.apple.main-thread
Thread 0 Crashed:
0   JavaScriptCore                	0x26f822b2 WTFCrash + 54 (Assertions.cpp:321)
1   WebKit                        	0x2a651d0e WebKit::WebProcess::networkConnection() + 30 (WebProcess.cpp:1023)
2   WebKit                        	0x2a50edba WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL(OpaqueCFHTTPCookieStorage*, __CFURL const*) + 98 (CookieStorageShim.mm:64)
3   WebKit                        	0x2a50f302 std::__1::__function::__func<-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]::$_0, std::__1::allocator<-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]::$_0>, void ()>::operator()() + 70 (CookieStorageShim.mm:123)
4   JavaScriptCore                	0x26f913de WTF::RunLoop::performWork() + 542 (functional:1793)
5   JavaScriptCore                	0x26f91736 WTF::RunLoop::performWork(void*) + 18 (RunLoopCF.cpp:38)
6   CoreFoundation                	0x257fc5a0 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 12 (CFRunLoop.c:1765)
7   CoreFoundation                	0x257fc18c __CFRunLoopDoSources0 + 448 (CFRunLoop.c:1811)
8   CoreFoundation                	0x257fa4ce __CFRunLoopRun + 790 (CFRunLoop.c:2540)
9   CoreFoundation                	0x2574b92c CFRunLoopRunSpecific + 516 (CFRunLoop.c:2818)
10  CoreFoundation                	0x2574b718 CFRunLoopRunInMode + 104 (CFRunLoop.c:2848)
11  Foundation                    	0x2656fffc -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 264 (NSRunLoop.m:366)
12  Foundation                    	0x265bee30 -[NSRunLoop(NSRunLoop) run] + 76 (NSRunLoop.m:388)
13  libxpc.dylib                  	0x37cf95c4 _xpc_objc_main + 604 (main.m:176)
14  libxpc.dylib                  	0x37cfac88 xpc_main + 164 (init.c:1424)
15  com.apple.WebKit.WebContent   	0x000fba2c main + 184 (XPCServiceMain.mm:89)
16  libdyld.dylib                 	0x37b6a9cc start + 0 (start_glue.s:64)

Comment 1 Daniel Bates 2015-07-20 10:54:33 PDT

This controlled crash can happen when the network process crashes and then the newly launched network process is jetsam'd.

Comment 2 Daniel Bates 2015-07-20 10:56:21 PDT

Created attachment 257101 [details]
Patch

Comment 3 Daniel Bates 2015-07-21 15:29:14 PDT

Created attachment 257209 [details]
Patch

Comment 4 Daniel Bates 2015-07-21 15:35:09 PDT

Comment on attachment 257209 [details]
Patch

Clearing flags on attachment: 257209

Committed r187129: <http://trac.webkit.org/changeset/187129>

Comment 5 Daniel Bates 2015-07-21 15:35:14 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Alex Christensen 2015-07-21 16:04:47 PDT

This broke the GTK build.

Comment 7 Daniel Bates 2015-07-21 16:35:48 PDT

(In reply to comment #6)
> This broke the GTK build.

Committed build fix in <http://trac.webkit.org/changeset/187136>.