Bug 147079

Summary:

[Mac] Media Session: add support for more telephony interruptions

Product:

WebKit

Reporter:

Matt Rajca <mrajca>

Component:

Media

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

conrad_shultz, eric.carlson, mrajca, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

145411

Attachments:

Description	Flags
Patch	eric.carlson: review+

Description Matt Rajca 2015-07-18 21:34:31 PDT

- End 'Transient' interruptions when ringing stops
- Start 'Content' interruptions when calls connect

Comment 1 Radar WebKit Bug Importer 2015-07-18 21:35:08 PDT

<rdar://problem/21890357>

Comment 2 Matt Rajca 2015-07-18 21:39:07 PDT

Created attachment 257049 [details]
Patch

Comment 3 Eric Carlson 2015-07-30 10:45:29 PDT

Comment on attachment 257049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257049&action=review

> Source/WebCore/ChangeLog:3
> +        Media Session: add support for more telephony interruptions

Nit: The title should probably reflect that the changes are Mac only, eg. something like "[Mac] Media Session: add support for more telephony interruptions"

Comment 4 Matt Rajca 2015-07-30 15:26:00 PDT

(In reply to comment #3)
> Comment on attachment 257049 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257049&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Media Session: add support for more telephony interruptions
> 
> Nit: The title should probably reflect that the changes are Mac only, eg.
> something like "[Mac] Media Session: add support for more telephony
> interruptions"

Renamed.

Comment 5 Matt Rajca 2015-07-30 15:28:10 PDT

Committed r187613: <http://trac.webkit.org/changeset/187613>