Bug 147059

Summary: [El Capitan] Test gardening
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch commit-queue: commit-queue-

Myles C. Maxfield
Reported 2015-07-17 16:55:14 PDT
[El Capitan] Test gardening
Attachments
Patch (1.17 MB, patch)
2015-07-17 17:00 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.67 MB, patch)
2015-07-20 14:57 PDT, Myles C. Maxfield 		commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2015-07-17 17:00:57 PDT
Created attachment 257005 [details] Patch
Alexey Proskuryakov
Comment 2 2015-07-17 20:50:40 PDT
Comment on attachment 257005 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257005&action=review > LayoutTests/ChangeLog:8 > + * platform/mac/fast/dom/52776-expected.png: Is the ChangeLog incomplete? It doesn't mention moving old results to platform/mac-yosemite.
Alexey Proskuryakov
Comment 3 2015-07-17 20:52:25 PDT
Quickly scrolling through the patch, I didn't see Yosemite results added, which seems wrong. EWS is green because it's on Mavericks.
Myles C. Maxfield
Comment 4 2015-07-20 14:25:50 PDT
(In reply to comment #3) > Quickly scrolling through the patch, I didn't see Yosemite results added, > which seems wrong. EWS is green because it's on Mavericks. You're right. I wanted to make sure that Mavericks still works though. I'll add Yosemite results today.
Myles C. Maxfield
Comment 5 2015-07-20 14:57:55 PDT
Created attachment 257128 [details] Patch
WebKit Commit Bot
Comment 6 2015-07-20 17:10:06 PDT
Comment on attachment 257128 [details] Patch Rejecting attachment 257128 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 257128, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5000141605961728
Myles C. Maxfield
Comment 7 2015-07-21 14:44:28 PDT
Committed r187126: <http://trac.webkit.org/changeset/187126>
Note You need to log in before you can comment on or make changes to this bug.