[iOS] Menu drop down such as on nike.com does not stay

• Component: Layout and Rendering
• Status: REOPENED ---

[zalan]

1. Navigate to nike.com
2. Tap on the top menu bar: Men, Women, Boys etc..
3. The pull down menu does not stay.

[zalan]

rdar://problem/21046961

[zalan]

Created attachment 257014 [details]
Patch

[zalan]

Created attachment 257015 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 257015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257015&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:969
> +            if (!oldUnobscuredContentRect.isEmpty() && oldUnobscuredContentRect.y() < 1) {

oldUnobscuredContentRect.y() < 1 is true for RTL pages. Please test one.

[zalan]

(In reply to comment #4)
> Comment on attachment 257015 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257015&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:969
> > +            if (!oldUnobscuredContentRect.isEmpty() && oldUnobscuredContentRect.y() < 1) {
> 
> oldUnobscuredContentRect.y() < 1 is true for RTL pages. Please test one.

Works fine on nike.com with body dir=rtl

[Benjamin Poulain]

Comment on attachment 257015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257015&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:967
> +            // FIXME: We need to support programmatic scroll-after-viewport update.

I think this is no longer true. In RemoteLayerTreeDrawingAreaProxy::commitLayerTree(), didCommitLayerTree() is before requestScroll().

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:974
> +                [_scrollView zoomToRect: { newTopLeft, rectToZoomSize } animated:NO];

Can you double check that the zoom rect used here does not depend on the ContentInset of UIScrollView?

Here we are only using the bounds.

[zalan]

Created attachment 257202 [details]
Patch

[zalan]

(In reply to comment #6)
> Comment on attachment 257015 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257015&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:967
> > +            // FIXME: We need to support programmatic scroll-after-viewport update.
> 
> I think this is no longer true. In
> RemoteLayerTreeDrawingAreaProxy::commitLayerTree(), didCommitLayerTree() is
> before requestScroll().
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:974
> > +                [_scrollView zoomToRect: { newTopLeft, rectToZoomSize } animated:NO];
> 
> Can you double check that the zoom rect used here does not depend on the
> ContentInset of UIScrollView?
> 
> Here we are only using the bounds.
Tested with landscape mode with the sidebar open.

[WebKit Commit Bot]

Comment on attachment 257202 [details]
Patch

Clearing flags on attachment: 257202

Committed r187131: <http://trac.webkit.org/changeset/187131>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 147839