Bug 147030

Summary: Remove DFG::DesiredWriteBarriers because it's just a very difficult way of saying "please barrier the machine code block owner"
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 146929    
Attachments:
Description Flags
the patch kling: review+

Filip Pizlo
Reported 2015-07-16 20:01:16 PDT
Just doing: vm.heap.writeBarrier(codeBlock->ownerExecutable() somewhere in Plan is equivalent to all of what DesiredWriteBarriers amounts to, since: - All of the uses of it pass codeBlock->ownerExecutable() as the owner. - It's guaranteed that a barrier on the owner executable will be executed as a result of compilation, so we might as well just do it unconditionally.
Attachments
the patch (20.66 KB, patch)
2015-07-16 20:03 PDT, Filip Pizlo 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-07-16 20:03:59 PDT
Created attachment 256954 [details] the patch
Andreas Kling
Comment 2 2015-07-17 13:52:50 PDT
Comment on attachment 256954 [details] the patch r=me
Filip Pizlo
Comment 3 2015-07-17 22:51:05 PDT
Landed in http://trac.webkit.org/changeset/186985
Note You need to log in before you can comment on or make changes to this bug.