Bug 147025

Summary:

Web Inspector: REGRESSION (r186218) ScriptTimelineRecord attempts to access null property

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Matt Baker 2015-07-16 18:39:17 PDT

* SUMMARY
ScriptTimelineRecord attempts to access null property.

* STEPS TO REPRODUCE
1. Create a new timeline recording, one which includes script calls (Reloading daringfireball.net is sufficient)
2. Select the JavaScript & Events timeline
3. Select the Rendering Frames view
  => ScriptTimelineRecord:107: nodePayload has a property "calls", but it's null.

* NOTES
When the exception is thrown the nodePayload appears to be a ProfileNode rather than payload data. This explains why it has a "calls" property, however I'm not sure why we have a ProfileNode here, rather than payload data.

Comment 1 Radar WebKit Bug Importer 2015-07-16 18:39:50 PDT

<rdar://problem/21868062>

Comment 2 Joseph Pecoraro 2015-07-16 19:35:46 PDT

Created attachment 256950 [details]
[PATCH] Proposed Fix

Comment 3 WebKit Commit Bot 2015-07-16 21:00:36 PDT

Comment on attachment 256950 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 256950

Committed r186926: <http://trac.webkit.org/changeset/186926>

Comment 4 WebKit Commit Bot 2015-07-16 21:00:40 PDT

All reviewed patches have been landed.  Closing bug.