Bug 146989

Summary: [Win] 64-bit Build Failure
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: JavaScriptCoreAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, mark.lam, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Patch mark.lam: review+

Description Brent Fulgham 2015-07-15 16:00:26 PDT 
The 64-bit Windows build fails due to a missing CCallHelpers.h method.
Comment 1 Brent Fulgham 2015-07-15 16:02:22 PDT 
Created attachment 256874 [details]
Patch
Comment 2 Mark Lam 2015-07-15 16:14:37 PDT 
Comment on attachment 256874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256874&action=review

r=me

> Source/JavaScriptCore/jit/CCallHelpers.h:1537
> +#if OS(WINDOWS) && CPU(X86_64)

I think this #if is not needed because this function is always valid for the NUMBER_OF_ARGUMENT_REGISTERS == 4 case.  However, since this function seems to only be needed by Windows for now, I’m ok with leaving the #if in.
Comment 3 Saam Barati 2015-07-15 16:36:14 PDT 
(In reply to comment #0)
> The 64-bit Windows build fails due to a missing CCallHelpers.h method.

Thanks Brent.
Comment 4 Brent Fulgham 2015-07-15 17:31:32 PDT 
Comment on attachment 256874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256874&action=review

>> Source/JavaScriptCore/jit/CCallHelpers.h:1537
>> +#if OS(WINDOWS) && CPU(X86_64)
> 
> I think this #if is not needed because this function is always valid for the NUMBER_OF_ARGUMENT_REGISTERS == 4 case.  However, since this function seems to only be needed by Windows for now, I’m ok with leaving the #if in.

OK. I'll remove it while landing.
Comment 5 Brent Fulgham 2015-07-15 17:32:28 PDT 
Committed r186876: <http://trac.webkit.org/changeset/186876>