Bug 146984

Summary: Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dbates: review+
Another patch
ap: review-, ap: commit-queue-
Updated patch none

Description Anders Carlsson 2015-07-15 15:42:57 PDT 
Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
Comment 1 Anders Carlsson 2015-07-15 15:44:32 PDT 
Created attachment 256870 [details]
Patch
Comment 2 Anders Carlsson 2015-07-16 10:22:52 PDT 
Committed r186894: <http://trac.webkit.org/changeset/186894>
Comment 3 Aakash Jain 2016-02-04 11:57:56 PST 
Created attachment 270678 [details]
Another patch

Further changes.
Comment 4 Alexey Proskuryakov 2016-02-04 14:51:29 PST 
Comment on attachment 270678 [details]
Another patch

r- since the build is broken, per EWS.
Comment 5 Aakash Jain 2016-02-08 16:11:54 PST 
Created attachment 270892 [details]
Updated patch

reverted bindings/objc/WebScriptObject.h, we don't really need that change.
Comment 6 Alexey Proskuryakov 2016-02-09 20:47:35 PST 
Comment on attachment 270892 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270892&action=review

> Source/WebCore/platform/ios/wak/WebCoreThread.h:36
> +// Use __has_include here so that things work when rewritten into WebKitLegacy headers.
> +#if __has_include(<WebCore/PlatformExportMacros.h>)
> +#import <WebCore/PlatformExportMacros.h>
> +#endif

This is not great, because the cruft leaks into WebKitLegacy SPI headers. But it seems OK to me.
Comment 7 WebKit Commit Bot 2016-02-09 21:36:51 PST 
Comment on attachment 270892 [details]
Updated patch

Clearing flags on attachment: 270892

Committed r196360: <http://trac.webkit.org/changeset/196360>