Bug 146984

Summary: Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, cdumez, commit-queue, dbates, esprehn+autocc, kangil.han
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
dbates: review+
Another patch
ap: review-, ap: commit-queue-
Updated patch none

Anders Carlsson
Reported 2015-07-15 15:42:57 PDT
Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
Attachments
Patch (10.18 KB, patch)
2015-07-15 15:44 PDT, Anders Carlsson 		dbates: review+
DetailsFormatted DiffDiff
Another patch (4.65 KB, patch)
2016-02-04 11:57 PST, Aakash Jain 		ap: review-
ap: commit-queue-
DetailsFormatted DiffDiff
Updated patch (3.95 KB, patch)
2016-02-08 16:11 PST, Aakash Jain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2015-07-15 15:44:32 PDT
Created attachment 256870 [details] Patch
Anders Carlsson
Comment 2 2015-07-16 10:22:52 PDT
Committed r186894: <http://trac.webkit.org/changeset/186894>
Aakash Jain
Comment 3 2016-02-04 11:57:56 PST
Created attachment 270678 [details] Another patch Further changes.
Alexey Proskuryakov
Comment 4 2016-02-04 14:51:29 PST
Comment on attachment 270678 [details] Another patch r- since the build is broken, per EWS.
Aakash Jain
Comment 5 2016-02-08 16:11:54 PST
Created attachment 270892 [details] Updated patch reverted bindings/objc/WebScriptObject.h, we don't really need that change.
Alexey Proskuryakov
Comment 6 2016-02-09 20:47:35 PST
Comment on attachment 270892 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=270892&action=review > Source/WebCore/platform/ios/wak/WebCoreThread.h:36 > +// Use __has_include here so that things work when rewritten into WebKitLegacy headers. > +#if __has_include(<WebCore/PlatformExportMacros.h>) > +#import <WebCore/PlatformExportMacros.h> > +#endif This is not great, because the cruft leaks into WebKitLegacy SPI headers. But it seems OK to me.
WebKit Commit Bot
Comment 7 2016-02-09 21:36:51 PST
Comment on attachment 270892 [details] Updated patch Clearing flags on attachment: 270892 Committed r196360: <http://trac.webkit.org/changeset/196360>
Note You need to log in before you can comment on or make changes to this bug.