Bug 146965

Summary:

[GTK] Input method filter is always enabled when the view is focused

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, mrobinson, svillar, zan

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Updated patch	mrobinson: review+

Description Carlos Garcia Campos 2015-07-15 04:14:32 PDT

It should only be enabled when the view is focused and there's an editable element focused. In r138544, when input methods were implemented, the message SetInputMethodState was added, but it was never used. Instead, the notifyFocusIn method of the IM filter enables the input method unconditionally. We should actually use the SetInputMethodState message to enable/disable input methods when editable elements are focused/unfocused.

Comment 1 Carlos Garcia Campos 2015-07-15 04:21:28 PDT

Created attachment 256832 [details]
Patch

Comment 2 Carlos Garcia Campos 2015-07-15 05:21:36 PDT

Created attachment 256833 [details]
Updated patch

Also avoids updating the cursor rect if input methods are disabled.

Comment 3 Martin Robinson 2015-07-15 07:47:22 PDT

Comment on attachment 256833 [details]
Updated patch

Seems reasonable to me.

Comment 4 Carlos Garcia Campos 2015-07-15 22:33:16 PDT

Committed r186888: <http://trac.webkit.org/changeset/186888>