Bug 146965

Summary: [GTK] Input method filter is always enabled when the view is focused
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, svillar, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch mrobinson: review+

Carlos Garcia Campos
Reported 2015-07-15 04:14:32 PDT
It should only be enabled when the view is focused and there's an editable element focused. In r138544, when input methods were implemented, the message SetInputMethodState was added, but it was never used. Instead, the notifyFocusIn method of the IM filter enables the input method unconditionally. We should actually use the SetInputMethodState message to enable/disable input methods when editable elements are focused/unfocused.
Attachments
Patch (6.50 KB, patch)
2015-07-15 04:21 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Updated patch (6.87 KB, patch)
2015-07-15 05:21 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-07-15 04:21:28 PDT
Created attachment 256832 [details] Patch
Carlos Garcia Campos
Comment 2 2015-07-15 05:21:36 PDT
Created attachment 256833 [details] Updated patch Also avoids updating the cursor rect if input methods are disabled.
Martin Robinson
Comment 3 2015-07-15 07:47:22 PDT
Comment on attachment 256833 [details] Updated patch Seems reasonable to me.
Carlos Garcia Campos
Comment 4 2015-07-15 22:33:16 PDT
Committed r186888: <http://trac.webkit.org/changeset/186888>
Note You need to log in before you can comment on or make changes to this bug.