Bug 146928

Summary: Programmatic scrolling in RTL documents is no longer compatible with other browsers in WK2
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cmarcelo, commit-queue, jamesr, luiz, rniwa, simon.fraser, tonikitoo, webkit-bug-importer, zcorpan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=94405
Attachments:
Description Flags
Testcase
none
WIP patch
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-mavericks
none
Archive of layout-test-results from ews106 for mac-mavericks-wk2 none

Description Simon Fraser (smfr) 2015-07-13 22:18:56 PDT 
Created attachment 256756 [details]
Testcase

A programmatic document scroll in a RTL document behaves differently between WK2 and WK1, and between WK2 and Firefox. So WK2 broke compat with other browsers.

After:
                window.scrollTo(-50, 0);

window.scrollX is -870 in WK2, but -50 in WK1 and other browsers.

rdar://problem/21770741
Comment 1 Simon Fraser (smfr) 2015-07-13 22:19:55 PDT 
Created attachment 256757 [details]
WIP patch
Comment 2 WebKit Commit Bot 2015-07-13 22:23:04 PDT 
Attachment 256757 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2015-07-13 22:51:23 PDT 
Comment on attachment 256757 [details]
WIP patch

Attachment 256757 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6567680114950144

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2015-07-13 22:51:27 PDT 
Created attachment 256758 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-07-13 22:53:10 PDT 
Comment on attachment 256757 [details]
WIP patch

Attachment 256757 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4885281295564800

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2015-07-13 22:53:13 PDT 
Created attachment 256759 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Simon Fraser (smfr) 2016-01-02 22:01:23 PST 
Fixed in https://trac.webkit.org/changeset/194487