Bug 146927
| Summary: | Clean up scrollOffset/scrollPosition/scrollOrigin | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | sam, thorton |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
We're really confused about scrollOffset/scrollPosition/scrollOrigin.
Need to use consistent terms, possibly make it strongly typed. Need to decide on IntPoint/FloatPoint/LayoutPoint for units.
Some code to clean up:
* Move ScrollView::adjustScrollPositionWithinRange() into ScrollableArea, use it in ScrollAnimatorMac::adjustScrollPositionIfNecessary().
* Use it in ScrollView::setScrollOffset()
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |