Summary: | `display: block; width: 100%` makes <input type="range">'s thumb get clipped | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Rebert <webkit> | ||||||||
Component: | CSS | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, ddkilzer, simon.fraser, webkit-bug-importer, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
URL: | http://jsfiddle.net/cvrebert/0uzk6f4c/ | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 159753 | ||||||||||
Attachments: |
|
Description
Chris Rebert
2015-07-12 19:34:35 PDT
(This is using Safari Version 8.0.7 (10600.7.12).) Filed a Radar for this: <rdar://problem/21787807> This bug also affects iOS 8.4. Seems that any range slider over about 400px wide causes thumb clipping. The wider it is, the more the clipping. RenderSliderContainer::layout() repositions the thumb box but does not issue repaint. Default display: inline works due to inline painting (see RenderBlockFlow::layoutBlock()) we just need to issue a repaint for the thumb after we repositioned it. diff --git a/Source/WebCore/html/shadow/SliderThumbElement.cpp b/Source/WebCore/html/shadow/SliderThumbElement.cpp index 4bd22cc..0a1bb83 100644 --- a/Source/WebCore/html/shadow/SliderThumbElement.cpp +++ b/Source/WebCore/html/shadow/SliderThumbElement.cpp @@ -190,6 +190,7 @@ void RenderSliderContainer::layout() else thumbLocation.setX(thumbLocation.x() - offset); thumb->setLocation(thumbLocation); + thumb->repaint(); } Created attachment 256983 [details]
Patch
Comment on attachment 256983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256983&action=review > Source/WebCore/ChangeLog:3 > + `display: block; width: 100%` makes <input type="range">'s thumb get clipped icky backticks Created attachment 256984 [details]
Patch
Comment on attachment 256984 [details] Patch Clearing flags on attachment: 256984 Committed r186981: <http://trac.webkit.org/changeset/186981> All reviewed patches have been landed. Closing bug. Thanks for the fix! I will remove the corresponding entry from http://getbootstrap.com/browser-bugs shortly. (In reply to comment #12) > Thanks for the fix! I will remove the corresponding entry from > http://getbootstrap.com/browser-bugs shortly. Thanks for filing the bug! (In reply to comment #13) > (In reply to comment #12) > > Thanks for the fix! I will remove the corresponding entry from > > http://getbootstrap.com/browser-bugs shortly. > Thanks for filing the bug! ...report :) Tried to fix flaky test in r186994: <http://trac.webkit.org/r186994> |