Bug 146882

Summary:

Web Inspector: Type profiler shows 'Undefined' annotation for functions with no return statements

Product:

WebKit

Reporter:

Saam Barati <saam>

Component:

Web Inspector

Assignee:

Saam Barati <saam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Saam Barati 2015-07-11 14:50:05 PDT

Even though JS implicitly returns undefined, we decided not to show
return types unless there is an explicit 'return <expr>' in the function. 
I'm not sure how this got reverted but I will fix it.

Comment 1 Radar WebKit Bug Importer 2015-07-11 14:50:18 PDT

<rdar://problem/21783141>

Comment 2 Saam Barati 2015-08-21 17:36:58 PDT

Created attachment 259688 [details]
patch

Comment 3 Joseph Pecoraro 2015-08-21 19:40:33 PDT

Comment on attachment 259688 [details]
patch

r=me, Though I wonder if we could write a test for this.

Comment 4 WebKit Commit Bot 2015-08-21 20:27:34 PDT

Comment on attachment 259688 [details]
patch

Clearing flags on attachment: 259688

Committed r188818: <http://trac.webkit.org/changeset/188818>

Comment 5 WebKit Commit Bot 2015-08-21 20:27:38 PDT

All reviewed patches have been landed.  Closing bug.