Bug 146882

Summary: Web Inspector: Type profiler shows 'Undefined' annotation for functions with no return statements
Product: WebKit Reporter: Saam Barati <saam>
Component: Web InspectorAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Saam Barati
Reported 2015-07-11 14:50:05 PDT
Even though JS implicitly returns undefined, we decided not to show return types unless there is an explicit 'return <expr>' in the function. I'm not sure how this got reverted but I will fix it.
Attachments
patch (3.34 KB, patch)
2015-08-21 17:36 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-11 14:50:18 PDT
<rdar://problem/21783141>
Saam Barati
Comment 2 2015-08-21 17:36:58 PDT
Created attachment 259688 [details] patch
Joseph Pecoraro
Comment 3 2015-08-21 19:40:33 PDT
Comment on attachment 259688 [details] patch r=me, Though I wonder if we could write a test for this.
WebKit Commit Bot
Comment 4 2015-08-21 20:27:34 PDT
Comment on attachment 259688 [details] patch Clearing flags on attachment: 259688 Committed r188818: <http://trac.webkit.org/changeset/188818>
WebKit Commit Bot
Comment 5 2015-08-21 20:27:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.