Bug 146872

Summary: [iOS WK2] Scrolling issues on horizontally scrollable RTL pages
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, simon.fraser, thorton
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch sam: review+

Description Simon Fraser (smfr) 2015-07-10 22:14:26 PDT 
[iOS WK2] Scrolling issues on horizontally scrollable RTL pages
Comment 1 Simon Fraser (smfr) 2015-07-10 22:24:57 PDT 
Created attachment 256643 [details]
Patch
Comment 2 Simon Fraser (smfr) 2015-07-10 23:41:45 PDT 
Created attachment 256648 [details]
Patch
Comment 3 Simon Fraser (smfr) 2015-07-11 10:51:12 PDT 
Created attachment 256657 [details]
Patch
Comment 4 Sam Weinig 2015-07-11 10:58:11 PDT 
Comment on attachment 256657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256657&action=review

> Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:1250
> +    dumpProperty(ts, "transactionID", m_transactionID);

If we ever use this for tests, will putting the transactionID in the dump make it inconsistent. Or will we use a different dumping mechanism for testing.
Comment 5 Simon Fraser (smfr) 2015-07-11 11:21:43 PDT 
https://trac.webkit.org/r186712

rdar://problem/7569416
Comment 6 Tim Horton 2015-07-11 15:11:39 PDT 
(In reply to comment #4)
> Comment on attachment 256657 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256657&action=review
> 
> > Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm:1250
> > +    dumpProperty(ts, "transactionID", m_transactionID);
> 
> If we ever use this for tests, will putting the transactionID in the dump
> make it inconsistent. Or will we use a different dumping mechanism for
> testing.

I can't imagine that being any worse than the layer IDs, which are already in there.