Bug 146867

Summary: AI folding of IsObjectOrNull is broken for non-object types that may be null
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, rniwa, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch rniwa: review+

Description Filip Pizlo 2015-07-10 19:24:22 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2015-07-10 19:26:27 PDT 
Created attachment 256638 [details]
the patch
Comment 2 WebKit Commit Bot 2015-07-10 19:29:32 PDT 
Attachment 256638 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1044:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1053:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Ryosuke Niwa 2015-07-10 19:51:13 PDT 
Comment on attachment 256638 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256638&action=review

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1056
> +            if (!(child.m_type & ((SpecObject - SpecFunction) | SpecOther))) {

Can we define a local variable immediately before this line to reduce the number of parentheses involved?
e.g.
SpeculatedType nonFunctionObject = ((SpecObject - SpecFunction) | SpecOther);
Comment 4 Ryosuke Niwa 2015-07-10 19:53:24 PDT 
or maybe an inline helper function somewhere?
Comment 5 Filip Pizlo 2015-07-10 19:59:52 PDT 
(In reply to comment #3)
> Comment on attachment 256638 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=256638&action=review
> 
> > Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:1056
> > +            if (!(child.m_type & ((SpecObject - SpecFunction) | SpecOther))) {
> 
> Can we define a local variable immediately before this line to reduce the
> number of parentheses involved?
> e.g.
> SpeculatedType nonFunctionObject = ((SpecObject - SpecFunction) | SpecOther);

Well, we could, but nonFunctionObject would be the wrong name for this.  It's really nonFunctionObjectOrUndefinedOrNull.  At that point, the variable name is more complicated than the set expression!
Comment 6 Filip Pizlo 2015-07-10 20:00:07 PDT 
(In reply to comment #4)
> or maybe an inline helper function somewhere?

https://bugs.webkit.org/show_bug.cgi?id=146870
Comment 7 Filip Pizlo 2015-07-10 20:03:09 PDT 
Landed in http://trac.webkit.org/changeset/186702