text-align affects <select> button but not its drop-down menu

• Component: Forms
• Status: RESOLVED FIXED

In Windows Safari, <select> buttons respect the text-align property but their drop-down menus do not. See the attached test case and screenshot.

In Mac Safari, the popup menus are always left-aligned (I think this is an AppKit constraint in Tiger), and the buttons are styled to match.

In WinIE7, text-align is ignored, but the direction property is used to decide between left- and right-alignment. The right-to-left button also has the drop-down arrow on the left.

Regardless of whether Windows Safari matches Mac Safari in this regard or not, the alignment and writing direction in the drop-down should match those of the button itself.

Created attachment 15592 [details]
Test case

Created attachment 15593 [details]
Windows Safari rendering

Created attachment 15594 [details]
WinIE 7 rendering

I guess this was fixed at some point and then re-introduced in <http://trac.webkit.org/projects/webkit/changeset/21900> when fixing bug 13775 on the Mac. That patch coupled forced left-alignment with natural writing direction, and since Windows does not opt in for the latter, it no longer got the former.

To match Mac Safari, Windows can simply return true from PopupMenu::itemWritingDirectionIsNatural(). If Windows Safari is to have left alignment but specified writing direction, then either there should be a way for PopupMenu to specify those two features independently of each other, or PopupMenu can be given control over styling of the button (i.e. define a static function in PopupMenu that receives a RenderStyle and the item text and mutates the style as it sees fit to do).

[David Kilzer (:ddkilzer)]

<rdar://problem/5349755>

[Dave Hyatt]

We should match Mac I think.

Created attachment 16172 [details]
Use left alignment and natural writing direction in popup buttons and menus on Windows.

Matches Mac.

I think this bug is a regression from the first Windows beta...

Created attachment 16201 [details]
Use left alignment and natural writing direction in popup buttons and menus on Windows.

Matches the Mac behavior.

[Adam Roben (:aroben)]

Comment on attachment 16201 [details]
Use left alignment and natural writing direction in popup buttons and menus on Windows.

r=me

We should check in your testcase as a manual test (unless we have one already).

[Mark Rowe (bdash)]

Landed in r25386.