Summary: | [GTK] Add API to allow executing editing commands that require an argument | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andersca, darin, gustavo, mcrha, svillar, tpopela | ||||||||
Priority: | P2 | Keywords: | Gtk | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 145875 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2015-07-09 05:31:06 PDT
Created attachment 256480 [details]
Patch
Comment on attachment 256480 [details]
Patch
Is a single argument the only possibility, or are there editing commands that may take 2 or more?
(In reply to comment #2) > Comment on attachment 256480 [details] > Patch > > Is a single argument the only possibility, or are there editing commands > that may take 2 or more? Thanks for looking at it. There are no commands with more than one argument. If that eventually happens, we could add with_arguments() receiving the number of arguments and ... Comment on attachment 256480 [details]
Patch
OK =)
Created attachment 257163 [details]
Patch for EWS
Anders, Darin, could you guys confirm you are ok with the cross-platform changes? It simply adds an editing command argument parameter to the ExecuteEditCommand message.
Created attachment 257169 [details]
Try to fix IOS build
(In reply to comment #5) > Anders, Darin, could you guys confirm you are ok with the cross-platform > changes? It simply adds an editing command argument parameter to the > ExecuteEditCommand message. That part of the change looks fine to me. Committed r187220: <http://trac.webkit.org/changeset/187220> |