Bug 146781

Summary: [GTK] Add API to allow executing editing commands that require an argument
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, gustavo, mcrha, svillar, tpopela
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145875    
Bug Blocks:    
Attachments:
Description Flags
Patch
gustavo: review+
Patch for EWS
none
Try to fix IOS build none

Carlos Garcia Campos
Reported 2015-07-09 05:31:06 PDT
Commands like InsertImage or CreateLink receive an argument, but we only have webkit_web_view_execute_editing_command() that doesn't receive any argument. We need to add webkit_web_view_execute_editing_command_with_argument() for those commands.
Attachments
Patch (18.64 KB, patch)
2015-07-09 05:36 PDT, Carlos Garcia Campos 		gustavo: review+
DetailsFormatted DiffDiff
Patch for EWS (18.77 KB, patch)
2015-07-20 23:14 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Try to fix IOS build (19.55 KB, patch)
2015-07-21 00:34 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2015-07-09 05:36:53 PDT
Created attachment 256480 [details] Patch
Gustavo Noronha (kov)
Comment 2 2015-07-16 06:34:45 PDT
Comment on attachment 256480 [details] Patch Is a single argument the only possibility, or are there editing commands that may take 2 or more?
Carlos Garcia Campos
Comment 3 2015-07-16 06:50:16 PDT
(In reply to comment #2) > Comment on attachment 256480 [details] > Patch > > Is a single argument the only possibility, or are there editing commands > that may take 2 or more? Thanks for looking at it. There are no commands with more than one argument. If that eventually happens, we could add with_arguments() receiving the number of arguments and ...
Gustavo Noronha (kov)
Comment 4 2015-07-20 10:45:13 PDT
Comment on attachment 256480 [details] Patch OK =)
Carlos Garcia Campos
Comment 5 2015-07-20 23:14:14 PDT
Created attachment 257163 [details] Patch for EWS Anders, Darin, could you guys confirm you are ok with the cross-platform changes? It simply adds an editing command argument parameter to the ExecuteEditCommand message.
Carlos Garcia Campos
Comment 6 2015-07-21 00:34:21 PDT
Created attachment 257169 [details] Try to fix IOS build
Darin Adler
Comment 7 2015-07-22 13:47:50 PDT
(In reply to comment #5) > Anders, Darin, could you guys confirm you are ok with the cross-platform > changes? It simply adds an editing command argument parameter to the > ExecuteEditCommand message. That part of the change looks fine to me.
Carlos Garcia Campos
Comment 8 2015-07-23 01:24:55 PDT
Committed r187220: <http://trac.webkit.org/changeset/187220>
Note You need to log in before you can comment on or make changes to this bug.