Bug 146774

Summary: Fix grammar issue in TypeError attempting to change an unconfigurable property
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: JavaScriptCoreAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, commit-queue, ggaren, mark.lam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Description Joseph Pecoraro 2015-07-08 22:01:09 PDT
* SUMMARY
Fix grammar issue in TypeError attempting to change an unconfigurable property.

* TESTs
js> Object.defineProperty(function(){}, "name", {configurable:true})
  => TypeError: Attempting to configurable attribute of unconfigurable property.
js> Object.defineProperty(Object.defineProperty({}, 'foo', {value: 1}), 'foo', {value:2, configurable: true})
  => TypeError: Attempting to configurable attribute of unconfigurable property.

* NOTES
- Repeated in a few different places (e.g. JSFunction and JSObject above). Not sure how to trigger the StringObject instance.
Comment 1 Joseph Pecoraro 2015-07-08 22:02:02 PDT
Created attachment 256457 [details]
[PATCH] Proposed Fix
Comment 2 Brent Fulgham 2015-07-08 22:04:15 PDT
Comment on attachment 256457 [details]
[PATCH] Proposed Fix

r=me. Thank you for fixing this!
Comment 3 WebKit Commit Bot 2015-07-08 23:05:48 PDT
Comment on attachment 256457 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 256457

Committed r186584: <http://trac.webkit.org/changeset/186584>
Comment 4 WebKit Commit Bot 2015-07-08 23:05:51 PDT
All reviewed patches have been landed.  Closing bug.