Bug 146760

Summary: Expose bounds of AVVideoCaptureSource
Product: WebKit Reporter: Matthew Daiter <mdaiter>
Component: WebCore Misc.Assignee: Matthew Daiter <mdaiter>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, jonlee, mdaiter, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 146746    
Attachments:
Description Flags
Patch none

Matthew Daiter
Reported 2015-07-08 17:21:41 PDT
Need to expose width and height of AVVideoCaptureSource to correctly bound the box of getUserMedia()
Attachments
Patch (1.72 KB, patch)
2015-07-08 17:24 PDT, Matthew Daiter 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-08 17:23:29 PDT
<rdar://problem/21736772>
Matthew Daiter
Comment 2 2015-07-08 17:24:11 PDT
Created attachment 256437 [details] Patch
Brent Fulgham
Comment 3 2015-07-08 18:35:15 PDT
Comment on attachment 256437 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256437&action=review > Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:45 > + virtual int32_t height() const { return m_height; } Why are these virtual? Are they overridden in another class?
Brent Fulgham
Comment 4 2015-07-09 11:01:12 PDT
Comment on attachment 256437 [details] Patch r=me
WebKit Commit Bot
Comment 5 2015-07-09 11:49:59 PDT
Comment on attachment 256437 [details] Patch Clearing flags on attachment: 256437 Committed r186600: <http://trac.webkit.org/changeset/186600>
WebKit Commit Bot
Comment 6 2015-07-09 11:50:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.