Bug 146751

Summary:

Audio elements with controls force their enclosing stacking context to composite

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	simon.fraser: review+

Description Dean Jackson 2015-07-08 16:37:27 PDT

Audio elements with controls force their enclosing stacking context to composite

Comment 1 Dean Jackson 2015-07-08 16:38:41 PDT

<rdar://problem/21466572>

Comment 2 Dean Jackson 2015-07-08 16:45:49 PDT

Created attachment 256425 [details]
Patch

Comment 3 Simon Fraser (smfr) 2015-07-08 16:48:13 PDT

Comment on attachment 256425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256425&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:149
> +    background-color: #292929;

Don't we use rgb() syntax?

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:174
> +    z-index: 1;

z-index: 0 is enough if you're not fighting with another z-index.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:482
> +    color: #9c9c9c;

rgb()?

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:535
> +    color: #9c9c9c;

rgb?

Comment 4 Dean Jackson 2015-07-08 17:13:58 PDT

Committed r186543: <http://trac.webkit.org/changeset/186543>