Bug 146716

Summary: [EFL] When closing inspector window, EwkView is not released properly.
Product: WebKit Reporter: Jinwoo Song <jinwoo7.song>
Component: WebKit EFLAssignee: Jinwoo Song <jinwoo7.song>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lucas.de.marchi
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jinwoo Song 2015-07-08 01:02:35 PDT
When we close the inspector window, EwkView is not released with following messages. It's because inspector window could not be deleted by remaining references.

ERR<8388>:evas_main lib/evas/canvas/evas_main.c:237 _evas_canvas_eo_base_destructor() obj(0x4a9bf20, EWK2_View) ref count(2) is bigger than 0. This object couldn't be deleted
ERR<8388>:eo lib/eo/eo.c:1896 eo_manual_free() Tried deleting the object 0x800000b0c0000587 while still referenced(2).
ERR<8388>:eo lib/eo/eo.c:1896 eo_manual_free() Tried deleting the object 0x800000b0e0000588 while still referenced(1).
ERR<8388>:eo lib/eo/eo.c:1896 eo_manual_free() Tried deleting the object 0x800000b100000589 while still referenced(1).
Comment 1 Jinwoo Song 2015-07-08 01:07:44 PDT
Created attachment 256365 [details]
Patch
Comment 2 Gyuyoung Kim 2015-07-08 21:56:30 PDT
Comment on attachment 256365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256365&action=review

> Source/WebKit2/ChangeLog:9
> +        from inspector view(evas object). This patch delete the inspector window

s/delete/deletes/g
Comment 3 Jinwoo Song 2015-07-08 22:36:30 PDT
Comment on attachment 256365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256365&action=review

>> Source/WebKit2/ChangeLog:9
>> +        from inspector view(evas object). This patch delete the inspector window
> 
> s/delete/deletes/g

Fixed!
Comment 4 Jinwoo Song 2015-07-08 22:36:50 PDT
Created attachment 256459 [details]
Patch
Comment 5 WebKit Commit Bot 2015-07-08 23:02:06 PDT
Comment on attachment 256459 [details]
Patch

Clearing flags on attachment: 256459

Committed r186583: <http://trac.webkit.org/changeset/186583>
Comment 6 WebKit Commit Bot 2015-07-08 23:02:11 PDT
All reviewed patches have been landed.  Closing bug.