Bug 146707

Summary: [GTK] The "Missing Plug-in" buttons are not showing up on some flash contents
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: WebCore Misc.Assignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dbates, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the test content taken from http://www.youku.com/
none
Patch none

Sungmann Cho
Reported 2015-07-07 20:15:45 PDT
Created attachment 256350 [details] the test content taken from http://www.youku.com/ Currently, WebKitGTK+ doesn't show the "Missing Plug-in" buttons if the plugin-related tags don't have a "type" attribute. In such a case, WebCore tries to guess the MIME type from the extensions by using MIMETypeRegistry::getMIMETypeForExtension(). For WebKitGTK+, MIMETypeRegistry::getMIMETypeForExtension() goes through |extensionMap|, which is a simple array of <extension, mime type>, looking for the mime type for the given extension. But |extensionMap| in MIMETypeRegistryGtk.cpp doesn't have the information for ".swf", so WebCore fails to guess the MIME type and regard the content type as ObjectContentFrame, not ObjectContentNetscapePlugin.
Attachments
the test content taken from http://www.youku.com/ (354 bytes, text/html)
2015-07-07 20:15 PDT, Sungmann Cho 		no flags
Details
Patch (2.00 KB, patch)
2015-07-07 20:19 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2015-07-07 20:19:57 PDT
Created attachment 256351 [details] Patch
Martin Robinson
Comment 2 2015-07-08 22:01:21 PDT
Comment on attachment 256351 [details] Patch Seems reasonable to me.
WebKit Commit Bot
Comment 3 2015-07-08 22:51:43 PDT
Comment on attachment 256351 [details] Patch Clearing flags on attachment: 256351 Committed r186581: <http://trac.webkit.org/changeset/186581>
WebKit Commit Bot
Comment 4 2015-07-08 22:51:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.