Bug 146679

Summary:

REGRESSION(r183706): HTMLImageElement sometimes fails to register as document named item.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

Images

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, gyuyoung.kim, kling

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	koivisto: review+
Patch for landing	none

Description Andreas Kling 2015-07-07 01:33:30 PDT

<rdar://problem/21613839>

Comment 1 Andreas Kling 2015-07-07 01:39:29 PDT

Created attachment 256292 [details]
Patch

Comment 2 Antti Koivisto 2015-07-07 01:47:54 PDT

Comment on attachment 256292 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256292&action=review

> Source/WebCore/html/HTMLImageElement.h:135
> +    bool m_hadName { false }; // FIXME: We only need this because parseAttribute() can't see the old value.

This is bit misleading since most of the time it is really m_hasName.

Comment 3 Andreas Kling 2015-07-07 01:53:16 PDT

Created attachment 256293 [details]
Patch for landing

Comment 4 Andreas Kling 2015-07-07 08:55:22 PDT

Comment on attachment 256293 [details]
Patch for landing

Clearing flags on attachment: 256293

Committed r186461: <http://trac.webkit.org/changeset/186461>

Comment 5 Andreas Kling 2015-07-07 08:55:26 PDT

All reviewed patches have been landed.  Closing bug.