Bug 146679

Summary: REGRESSION(r183706): HTMLImageElement sometimes fails to register as document named item.
Product: WebKit Reporter: Andreas Kling <kling>
Component: ImagesAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, gyuyoung.kim, kling
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
koivisto: review+
Patch for landing none

Andreas Kling
Reported 2015-07-07 01:33:30 PDT
<rdar://problem/21613839>
Attachments
Patch (5.92 KB, patch)
2015-07-07 01:39 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Patch for landing (5.99 KB, patch)
2015-07-07 01:53 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-07-07 01:39:29 PDT
Created attachment 256292 [details] Patch
Antti Koivisto
Comment 2 2015-07-07 01:47:54 PDT
Comment on attachment 256292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256292&action=review > Source/WebCore/html/HTMLImageElement.h:135 > + bool m_hadName { false }; // FIXME: We only need this because parseAttribute() can't see the old value. This is bit misleading since most of the time it is really m_hasName.
Andreas Kling
Comment 3 2015-07-07 01:53:16 PDT
Created attachment 256293 [details] Patch for landing
Andreas Kling
Comment 4 2015-07-07 08:55:22 PDT
Comment on attachment 256293 [details] Patch for landing Clearing flags on attachment: 256293 Committed r186461: <http://trac.webkit.org/changeset/186461>
Andreas Kling
Comment 5 2015-07-07 08:55:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.