Bug 146665

Summary: Crash when setting text direction via MakeTextWritingDirection* editing commands.
Product: WebKit Reporter: Andreas Kling <kling>
Component: HTML EditingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
rniwa: review+
Latch for panding none

Description Andreas Kling 2015-07-06 17:27:54 PDT
<rdar://problem/20835477>
Comment 1 Andreas Kling 2015-07-06 17:28:12 PDT
*** Bug 146664 has been marked as a duplicate of this bug. ***
Comment 2 Andreas Kling 2015-07-06 17:31:05 PDT
Created attachment 256260 [details]
Patch
Comment 3 Ryosuke Niwa 2015-07-06 17:36:49 PDT
Comment on attachment 256260 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256260&action=review

> LayoutTests/editing/style/change-text-direction-crash-expected.txt:3
> +Dump of markup 1:

Can't we add a label here?
You can do Markup.dump('editor', command).
Comment 4 Andreas Kling 2015-07-06 17:39:34 PDT
Created attachment 256261 [details]
Latch for panding
Comment 5 WebKit Commit Bot 2015-07-06 18:38:43 PDT
Comment on attachment 256261 [details]
Latch for panding

Clearing flags on attachment: 256261

Committed r186393: <http://trac.webkit.org/changeset/186393>
Comment 6 WebKit Commit Bot 2015-07-06 18:38:47 PDT
All reviewed patches have been landed.  Closing bug.