Bug 146656

Summary:

[Content Extensions] Increase maxNFASize

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebCore Misc.

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	benjamin: review+

Alex Christensen

Reported 2015-07-06 15:32:58 PDT

Here's some data from a large test case: maxNFASize 30000 nfa 1.7MB dfa 10.3MB compiling time > 5 min maxNFASize 35000 nfa 1.9MB dfa 12.9MB compiling time 21 minutes (yes, minutes) byte code size 248MB maxNFASize 40000 nfa 2.2MB dfa 12.9MB compiling time 24.9 seconds byte code size 26.3 MB maxNFASize 50000 nfa 2.7MB dfa 16.2MB compiling time 13.8 seconds byte code size 24.9MB maxNFASize 75000 nfa 4.1MB dfa 20.5MB compiling time 11.3 seconds byte code size 25.7MB maxNFASize 100000 nfa 5.6MB dfa 31.7MB compiling time 11.24 seconds byte code size 26.6MB

Attachments
Patch (1.73 KB, patch) 2015-07-06 15:38 PDT, Alex Christensen	benjamin: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2015-07-06 15:38:31 PDT

Created attachment 256247 [details] Patch

Ahmad Saleem

Comment 2 2022-10-05 15:05:25 PDT

Webkit GitHub source show that this value has been updated: https://github.com/WebKit/WebKit/blob/main/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp#L199 and this landed here: https://github.com/WebKit/WebKit/commit/52f1ef2de1fb34209e9540091aa46e665f45339c Marking as "RESOLVED FIXED".

Note You need to log in before you can comment on or make changes to this bug.