Bug 14664

Summary: Misaligned logo on www.nzherald.co.nz possibly due to negative margin-top
Product: WebKit Reporter: Darren Collins <darrencollins>
Component: Layout and RenderingAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, darren, eric, jer.noble, ojan.autocc, rniwa, robert, webkit.review.bot
Priority: P2 Keywords: HasReduction
Version: 523.x (Safari 3)   
Hardware: PC   
OS: Windows XP   
URL: http://www.nzherald.co.nz
Attachments:
Description Flags
Screenshot with misaligned logo circled in red
none
Reduction
none
Image used by reduction
none
Patch none

Description Darren Collins 2007-07-18 13:47:19 PDT
The main logo on www.nzherald.co.nz is not aligned to the left when using Safari 3.0.2 and local builds up to r24395 on Windows XP.  Screenshot attached.  On Firefox and IE the logo is correctly aligned.  I have not tested on OS X or Safari 2.
Comment 1 Darren Collins 2007-07-18 13:48:31 PDT
Created attachment 15567 [details]
Screenshot with misaligned logo circled in red
Comment 2 Darren Collins 2007-07-18 13:51:40 PDT
Created attachment 15568 [details]
Reduction

reduction.  Note that margin-top on the div must be negative to trigger the problem.  Firefox and IE display "should be aligned to left" text aligned to the left.  Safari 3.0.2 on WinXP displays text aligned to left of second image.
Comment 3 Darren Collins 2007-07-18 13:52:09 PDT
Created attachment 15569 [details]
Image used by reduction
Comment 4 David Kilzer (:ddkilzer) 2007-07-18 23:40:59 PDT
Opera 9.21 agrees with my local build of WebKit r24439 with Safari 3.0 (522.12) on Mac OS X 10.4.10 (8R218) in that it shows the text aligned with the second image.

Firefox 3.0a7 and 2.0.0.4 show the text aligned below the left-most (first) image.

What does MSIE 6 or 7 do?

Confirming bug due to difference in rendering.  Not sure if it's correct or not, though.

Comment 5 David Kilzer (:ddkilzer) 2007-07-18 23:41:41 PDT
Not a regression as Safari 2.0.4 (419.3) with original WebKit on 10.4.10 behaves the same was as Safari 3.0.

Comment 6 Darren Collins 2007-07-19 01:22:08 PDT
MSIE 6 and 7 both align below the left-most image as per Firefox.
Comment 7 Dave Hyatt 2007-09-27 15:12:42 PDT
Yeah, this is a bug.  It looks like when we shift to clear, we aren't properly figuring out that we no longer overlap the float.
Comment 8 Robert Hogan 2013-01-07 10:31:54 PST
Created attachment 181521 [details]
Patch
Comment 9 Build Bot 2013-01-07 11:25:20 PST
Comment on attachment 181521 [details]
Patch

Attachment 181521 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/15740766

New failing tests:
fast/block/float/024.html
fast/block/margin-collapse/empty-clear-blocks.html
Comment 10 Build Bot 2013-01-17 01:27:10 PST
Comment on attachment 181521 [details]
Patch

Attachment 181521 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/15914739

New failing tests:
fast/block/float/024.html
fast/block/margin-collapse/empty-clear-blocks.html
Comment 11 Dave Hyatt 2013-01-21 13:51:52 PST
Comment on attachment 181521 [details]
Patch

r=me
Comment 12 WebKit Review Bot 2013-01-21 13:59:52 PST
Comment on attachment 181521 [details]
Patch

Clearing flags on attachment: 181521

Committed r140358: <http://trac.webkit.org/changeset/140358>
Comment 13 WebKit Review Bot 2013-01-21 13:59:56 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 Jer Noble 2013-01-21 14:23:50 PST
Rebaselined mac expected results:

Committed r140363: <http://trac.webkit.org/changeset/140363>