Bug 146609

Summary: Web Inspector: Exceptions in Network timeline when resource updates and filters are applied
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Timothy Hatcher 2015-07-04 08:18:07 PDT 
TimelineDataGrid._refreshDirtyDataGridNodes can trigger exceptions in DataGrid.removeChild and TreeOutline.removeChild if it is run while a filter is applied. We should just convert these exceptions to early returns.

These exceptions break the UI hard, where things won't be added anymore to the DataGrid.
Comment 1 Radar WebKit Bug Importer 2015-07-04 08:18:25 PDT 
<rdar://problem/21674514>
Comment 2 Timothy Hatcher 2015-07-04 08:27:01 PDT 
Created attachment 256147 [details]
Patch
Comment 3 Joseph Pecoraro 2015-07-05 22:37:28 PDT 
Comment on attachment 256147 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2015-07-06 00:14:48 PDT 
Comment on attachment 256147 [details]
Patch

Clearing flags on attachment: 256147

Committed r186306: <http://trac.webkit.org/changeset/186306>
Comment 5 WebKit Commit Bot 2015-07-06 00:15:00 PDT 
All reviewed patches have been landed.  Closing bug.