Bug 146609

Summary: Web Inspector: Exceptions in Network timeline when resource updates and filters are applied
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Timothy Hatcher
Reported 2015-07-04 08:18:07 PDT
TimelineDataGrid._refreshDirtyDataGridNodes can trigger exceptions in DataGrid.removeChild and TreeOutline.removeChild if it is run while a filter is applied. We should just convert these exceptions to early returns. These exceptions break the UI hard, where things won't be added anymore to the DataGrid.
Attachments
Patch (6.44 KB, patch)
2015-07-04 08:27 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-07-04 08:18:25 PDT
<rdar://problem/21674514>
Timothy Hatcher
Comment 2 2015-07-04 08:27:01 PDT
Created attachment 256147 [details] Patch
Joseph Pecoraro
Comment 3 2015-07-05 22:37:28 PDT
Comment on attachment 256147 [details] Patch r=me
WebKit Commit Bot
Comment 4 2015-07-06 00:14:48 PDT
Comment on attachment 256147 [details] Patch Clearing flags on attachment: 256147 Committed r186306: <http://trac.webkit.org/changeset/186306>
WebKit Commit Bot
Comment 5 2015-07-06 00:15:00 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.