Bug 146601

Summary: OSR exit fuzzing should allow us to select a static exit site
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Description Filip Pizlo 2015-07-03 19:47:30 PDT
This prevents fuzzing from biasing to the hottest exit sites.
Comment 1 Filip Pizlo 2015-07-03 19:51:14 PDT
Created attachment 256128 [details]
the patch
Comment 2 WebKit Commit Bot 2015-07-03 19:54:18 PDT
Attachment 256128 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGOSRExitFuzz.h:33:  g_numberOfStaticOSRExitFuzzChecks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/JavaScriptCore/dfg/DFGOSRExitFuzz.cpp:33:  g_numberOfStaticOSRExitFuzzChecks is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2015-07-09 12:45:13 PDT
Landed in http://trac.webkit.org/changeset/186605