| Summary: | [WinCairo] font fallback not working | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jinyoung Hur <hur.ims> | ||||||||||
| Component: | Text | Assignee: | Jinyoung Hur <hur.ims> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, darin, gyuyoung.kim, mmaxfield | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Windows 7 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 256111 [details]
test page
Created attachment 256115 [details]
Patch
CC'ing Alex and Darin. Could you guys take a look this patch ? Created attachment 256836 [details]
test page
Comment on attachment 256115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256115&action=review This seems correct according to https://msdn.microsoft.com/en-us/library/windows/desktop/dd144890(v=vs.85).aspx but I'm not terribly familiar with the font fallback mechanism. > Source/WebCore/ChangeLog:10 > + I think a specific font should be newly installed on the test machine to test this case but I have no idea how can it be done. The WinCairo test machine doesn't run layout tests. Comment on attachment 256115 [details]
Patch
The font fallback mechanism looks fine, and I'm willing to believe Alex when he says that this obeys the Microsoft documentation. As such, r=me.
Comment on attachment 256115 [details] Patch Clearing flags on attachment: 256115 Committed r186862: <http://trac.webkit.org/changeset/186862> All reviewed patches have been landed. Closing bug. |
Created attachment 256110 [details] some chinese characters are rendered as a square All chinese characters are rendered as a square with a font that has no chinese characters itself. Font fallback mechanism seems not working on WinCairo port. In my case, the font face name is "Malgun Gothic", which is a default font on Windows7 in Korea and has no chinese glyph. A screenshot and a simple test page are attached.