Bug 146595

Summary:

[WinCairo] font fallback not working

Product:

WebKit

Reporter:

Jinyoung Hur <hur.ims>

Component:

Text

Assignee:

Jinyoung Hur <hur.ims>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, darin, gyuyoung.kim, mmaxfield

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
some chinese characters are rendered as a square	none
test page	none
Patch	none
test page	none

Jinyoung Hur

Reported 2015-07-03 10:58:58 PDT

Created attachment 256110 [details] some chinese characters are rendered as a square All chinese characters are rendered as a square with a font that has no chinese characters itself. Font fallback mechanism seems not working on WinCairo port. In my case, the font face name is "Malgun Gothic", which is a default font on Windows7 in Korea and has no chinese glyph. A screenshot and a simple test page are attached.

Attachments
some chinese characters are rendered as a square (161.89 KB, image/png) 2015-07-03 10:58 PDT, Jinyoung Hur	no flags	Details
test page (447 bytes, text/html) 2015-07-03 10:59 PDT, Jinyoung Hur	no flags	Details
Patch (2.17 KB, patch) 2015-07-03 11:42 PDT, Jinyoung Hur	no flags	Details Formatted Diff Diff
test page (447 bytes, text/html) 2015-07-15 06:22 PDT, Jinyoung Hur	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jinyoung Hur

Comment 1 2015-07-03 10:59:35 PDT

Created attachment 256111 [details] test page

Jinyoung Hur

Comment 2 2015-07-03 11:42:50 PDT

Created attachment 256115 [details] Patch

Gyuyoung Kim

Comment 3 2015-07-15 01:05:17 PDT

CC'ing Alex and Darin. Could you guys take a look this patch ?

Jinyoung Hur

Comment 4 2015-07-15 06:22:25 PDT

Created attachment 256836 [details] test page

Alex Christensen

Comment 5 2015-07-15 10:46:13 PDT

Comment on attachment 256115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256115&action=review This seems correct according to https://msdn.microsoft.com/en-us/library/windows/desktop/dd144890(v=vs.85).aspx but I'm not terribly familiar with the font fallback mechanism. > Source/WebCore/ChangeLog:10 > + I think a specific font should be newly installed on the test machine to test this case but I have no idea how can it be done. The WinCairo test machine doesn't run layout tests.

Myles C. Maxfield

Comment 6 2015-07-15 14:02:24 PDT

Comment on attachment 256115 [details] Patch The font fallback mechanism looks fine, and I'm willing to believe Alex when he says that this obeys the Microsoft documentation. As such, r=me.

WebKit Commit Bot

Comment 7 2015-07-15 14:55:57 PDT

Comment on attachment 256115 [details] Patch Clearing flags on attachment: 256115 Committed r186862: <http://trac.webkit.org/changeset/186862>

WebKit Commit Bot

Comment 8 2015-07-15 14:56:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.