Bug 146567

Summary:

Allow UIDelegate to customize link actions in preview.

Product:

WebKit

Reporter:

Yongjun Zhang <yongjun_zhang>

Component:

WebKit2

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, commit-queue, mitz, sam, thorton

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch.	none
Patch, fixed style violation.	bdakin: review+
Patch for landing.	none

Yongjun Zhang

Reported 2015-07-02 17:44:47 PDT

The link sheet actions should be customizable in preview view controller.

Attachments
Patch. (13.65 KB, patch) 2015-07-02 18:06 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
Patch, fixed style violation. (13.55 KB, patch) 2015-07-02 18:11 PDT, Yongjun Zhang	bdakin: review+	Details Formatted Diff Diff
Patch for landing. (13.79 KB, patch) 2015-07-06 13:32 PDT, Yongjun Zhang	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Yongjun Zhang

Comment 1 2015-07-02 18:06:32 PDT

Created attachment 256061 [details] Patch.

WebKit Commit Bot

Comment 2 2015-07-02 18:07:48 PDT

Attachment 256061 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3222: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Yongjun Zhang

Comment 3 2015-07-02 18:11:04 PDT

Created attachment 256062 [details] Patch, fixed style violation.

Tim Horton

Comment 4 2015-07-03 00:22:01 PDT

Comment on attachment 256062 [details] Patch, fixed style violation. View in context: https://bugs.webkit.org/attachment.cgi?id=256062&action=review > Source/WebKit2/ChangeLog:7 > + the client customize the actions based on the element. Also add a new SPI runActionWithElementInfo: ...allow the client [to] customize... > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:313 > + NSURL *targetURL = [NSURL URLWithString:positionInformation.url]; _web_URLWithWTFString, no?

Beth Dakin

Comment 5 2015-07-06 12:36:16 PDT

Comment on attachment 256062 [details] Patch, fixed style violation. View in context: https://bugs.webkit.org/attachment.cgi?id=256062&action=review >> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:313 >> + NSURL *targetURL = [NSURL URLWithString:positionInformation.url]; > > _web_URLWithWTFString, no? Even though this is existing code, this would be a good change to make.

Yongjun Zhang

Comment 6 2015-07-06 13:32:54 PDT

Created attachment 256236 [details] Patch for landing.

WebKit Commit Bot

Comment 7 2015-07-06 14:32:09 PDT

Comment on attachment 256236 [details] Patch for landing. Clearing flags on attachment: 256236 Committed r186377: <http://trac.webkit.org/changeset/186377>

WebKit Commit Bot

Comment 8 2015-07-06 14:32:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.