Summary: | Allow UIDelegate to customize link actions in preview. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yongjun Zhang <yongjun_zhang> | ||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bdakin, commit-queue, mitz, sam, thorton | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Yongjun Zhang
2015-07-02 17:44:47 PDT
Created attachment 256061 [details]
Patch.
Attachment 256061 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3222: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 256062 [details]
Patch, fixed style violation.
Comment on attachment 256062 [details] Patch, fixed style violation. View in context: https://bugs.webkit.org/attachment.cgi?id=256062&action=review > Source/WebKit2/ChangeLog:7 > + the client customize the actions based on the element. Also add a new SPI runActionWithElementInfo: ...allow the client [to] customize... > Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:313 > + NSURL *targetURL = [NSURL URLWithString:positionInformation.url]; _web_URLWithWTFString, no? Comment on attachment 256062 [details] Patch, fixed style violation. View in context: https://bugs.webkit.org/attachment.cgi?id=256062&action=review >> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:313 >> + NSURL *targetURL = [NSURL URLWithString:positionInformation.url]; > > _web_URLWithWTFString, no? Even though this is existing code, this would be a good change to make. Created attachment 256236 [details]
Patch for landing.
Comment on attachment 256236 [details] Patch for landing. Clearing flags on attachment: 256236 Committed r186377: <http://trac.webkit.org/changeset/186377> All reviewed patches have been landed. Closing bug. |