| Summary: | Creating bindings between WebCore, WebKit2 and Safari for getUserMedia | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Matthew Daiter <mdaiter> | ||||
| Component: | WebKit2 | Assignee: | Matthew Daiter <mdaiter> | ||||
| Status: | RESOLVED INVALID | ||||||
| Severity: | Normal | CC: | bfulgham, eric.carlson, jer.noble, mdaiter, webkit-bug-importer, webkit.review.bot | ||||
| Priority: | P2 | Keywords: | HTML5, InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Matthew Daiter
2015-07-02 15:33:53 PDT
Created attachment 256042 [details]
Patch
(In reply to comment #0) > Needed to create a LOT of binding work in Safari and some binding in WebKit2 > and WebCore between the three, in order to call getUserMedia Clarification: in order to be able for getUserMedia to actually call into the browser, prompt the user for media access, and then go ahead and try to assess the promise if the constraints are correct. Comment on attachment 256042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256042&action=review > Source/WebKit2/ChangeLog:12 > + (API::UIClient::decidePolicyForUserMediaPermissionRequest): Changed to pointers, > + like how Geolocation is doing it. No, please don’t do that. New code should use references in cases like this. Comment on attachment 256042 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=256042&action=review >> Source/WebKit2/ChangeLog:12 >> + like how Geolocation is doing it. > > No, please don’t do that. New code should use references in cases like this. Sure. You need to fix the gtk build failure as well: WebKitUIClient.cpp:170:18: error: 'virtual bool UIClient::decidePolicyForUserMediaPermissionRequest(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, API::SecurityOrigin&, WebKit::UserMediaPermissionRequestProxy&)' marked override, but does not override |