Bug 146560 – Creating bindings between WebCore, WebKit2 and Safari for getUserMedia

• Component: WebKit2
• Status: RESOLVED INVALID

[Matthew Daiter]

Needed to create a LOT of binding work in Safari and some binding in WebKit2 and WebCore between the three, in order to call getUserMedia

[Radar WebKit Bug Importer]

<rdar://problem/21661498>

[Matthew Daiter]

Created attachment 256042 [details]
Patch

[Matthew Daiter]

(In reply to comment #0)
> Needed to create a LOT of binding work in Safari and some binding in WebKit2
> and WebCore between the three, in order to call getUserMedia

Clarification: in order to be able for getUserMedia to actually call into the browser, prompt the user for media access, and then go ahead and try to assess the promise if the constraints are correct.

[Darin Adler]

Comment on attachment 256042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256042&action=review

> Source/WebKit2/ChangeLog:12
> +        (API::UIClient::decidePolicyForUserMediaPermissionRequest): Changed to pointers,
> +        like how Geolocation is doing it.

No, please don’t do that. New code should use references in cases like this.

[Matthew Daiter]

Comment on attachment 256042 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256042&action=review

>> Source/WebKit2/ChangeLog:12
>> +        like how Geolocation is doing it.
> 
> No, please don’t do that. New code should use references in cases like this.

Sure.

[Brent Fulgham]

You need to fix the gtk build failure as well:

WebKitUIClient.cpp:170:18: error: 'virtual bool UIClient::decidePolicyForUserMediaPermissionRequest(WebKit::WebPageProxy&, WebKit::WebFrameProxy&, API::SecurityOrigin&, WebKit::UserMediaPermissionRequestProxy&)' marked override, but does not override