Bug 146537

Summary: Re-enable WebGL on WinCairo
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dino, kondapallykalyan, peavo, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ossy: review+

Description Alex Christensen 2015-07-01 17:38:20 PDT 
This undoes r186172 but after r186201 should have fixed the WebGL build.
Comment 1 Alex Christensen 2015-07-01 17:39:57 PDT 
Created attachment 255978 [details]
Patch
Comment 2 Brent Fulgham 2015-07-01 17:45:26 PDT 
Comment on attachment 255978 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255978&action=review

> Source/WTF/wtf/FeatureDefines.h:303
> +#define ENABLE_WEBGL 1

Won't this cause our builds to try to use/link against WebGL?
Comment 3 Alex Christensen 2015-07-01 19:18:17 PDT 
Created attachment 255983 [details]
Patch
Comment 4 Alex Christensen 2015-07-01 19:19:27 PDT 
This should only affect WinCairo.  Also, it now requires the DirectX SDK that comes with Visual Studio 2013, not the June 2010 one.
Comment 5 Alex Christensen 2015-07-01 19:30:41 PDT 
Created attachment 255985 [details]
Patch
Comment 6 Alex Christensen 2015-07-01 22:22:52 PDT 
Created attachment 255991 [details]
Patch
Comment 7 WebKit Commit Bot 2015-07-01 22:25:11 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 8 Csaba Osztrogonác 2015-07-01 23:35:33 PDT 
Comment on attachment 255991 [details]
Patch

rs=me
Comment 9 Alex Christensen 2015-07-02 00:01:48 PDT 
http://trac.webkit.org/changeset/186220
I still need to uninstall the June 2010 DirectX SDK from the WinCairo bot, but this builds locally and shouldn't affect AppleWin.
Comment 10 peavo 2015-07-02 04:28:22 PDT 
(In reply to comment #9)
> http://trac.webkit.org/changeset/186220
> I still need to uninstall the June 2010 DirectX SDK from the WinCairo bot,
> but this builds locally and shouldn't affect AppleWin.

Thanks for fixing this!