Bug 146537

Summary: Re-enable WebGL on WinCairo
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dino, kondapallykalyan, peavo, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch ossy: review+

Alex Christensen
Reported 2015-07-01 17:38:20 PDT
This undoes r186172 but after r186201 should have fixed the WebGL build.
Attachments
Patch (13.97 KB, patch)
2015-07-01 17:39 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.81 KB, patch)
2015-07-01 19:18 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (6.81 KB, patch)
2015-07-01 19:30 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (10.44 KB, patch)
2015-07-01 22:22 PDT, Alex Christensen 		ossy: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-07-01 17:39:57 PDT
Created attachment 255978 [details] Patch
Brent Fulgham
Comment 2 2015-07-01 17:45:26 PDT
Comment on attachment 255978 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255978&action=review > Source/WTF/wtf/FeatureDefines.h:303 > +#define ENABLE_WEBGL 1 Won't this cause our builds to try to use/link against WebGL?
Alex Christensen
Comment 3 2015-07-01 19:18:17 PDT
Created attachment 255983 [details] Patch
Alex Christensen
Comment 4 2015-07-01 19:19:27 PDT
This should only affect WinCairo. Also, it now requires the DirectX SDK that comes with Visual Studio 2013, not the June 2010 one.
Alex Christensen
Comment 5 2015-07-01 19:30:41 PDT
Created attachment 255985 [details] Patch
Alex Christensen
Comment 6 2015-07-01 22:22:52 PDT
Created attachment 255991 [details] Patch
WebKit Commit Bot
Comment 7 2015-07-01 22:25:11 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Csaba Osztrogonác
Comment 8 2015-07-01 23:35:33 PDT
Comment on attachment 255991 [details] Patch rs=me
Alex Christensen
Comment 9 2015-07-02 00:01:48 PDT
http://trac.webkit.org/changeset/186220 I still need to uninstall the June 2010 DirectX SDK from the WinCairo bot, but this builds locally and shouldn't affect AppleWin.
peavo
Comment 10 2015-07-02 04:28:22 PDT
(In reply to comment #9) > http://trac.webkit.org/changeset/186220 > I still need to uninstall the June 2010 DirectX SDK from the WinCairo bot, > but this builds locally and shouldn't affect AppleWin. Thanks for fixing this!
Note You need to log in before you can comment on or make changes to this bug.