| Summary: | Disable experimental WebGL2 implementation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
| Component: | New Bugs | Assignee: | Dean Jackson <dino> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, mmaxfield, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Dean Jackson
2015-07-01 15:13:49 PDT
Our experimental implementation is not ready to be exposed. Not sure why we got two radars. Which one updates? Created attachment 255957 [details]
Patch
Comment on attachment 255957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255957&action=review > Source/WTF/wtf/FeatureDefines.h:766 > +#if !defined(ENABLE_WEBGL2) > +#define ENABLE_WEBGL2 0 > +#endif Why is this necessary? Weinig says we should be trying to pare down this file, not add to it. > Source/WebCore/bindings/js/JSCanvasRenderingContextCustom.cpp:42 > +#if ENABLE(WEBGL2) > +#include "JSWebGL2RenderingContext.h" > +#endif Don't we usually have a pattern to put these ENABLE() guards inside the header files themselves? rs=me Comment on attachment 255957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255957&action=review >> Source/WTF/wtf/FeatureDefines.h:766 >> +#endif > > Why is this necessary? Weinig says we should be trying to pare down this file, not add to it. I agree! I was the one who proposed removing this file :) But until there is a plan, I would like to keep consistent. >> Source/WebCore/bindings/js/JSCanvasRenderingContextCustom.cpp:42 >> +#endif > > Don't we usually have a pattern to put these ENABLE() guards inside the header files themselves? Good catch. It's actually automatically in that file thanks to the Condition guard. Committed r186198: <http://trac.webkit.org/changeset/186198> Look like this needs rebaselining: js/dom/global-constructors-attributes.html (In reply to comment #10) > Look like this needs rebaselining: > js/dom/global-constructors-attributes.html <http://trac.webkit.org/changeset/186211> |