Summary: | Never try to pass URLs to LaunchServices when they're the same domain as the current URL | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit2 | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ggaren, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2015-07-01 12:22:10 PDT
Created attachment 255947 [details]
Patch v1
Attachment 255947 [details] did not pass style-queue:
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:236: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:236: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:254: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:309: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 4 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|