Summary: | [Mac] Numerous CGColor leaks in swipe gestures | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | WebKit2 | Assignee: | Joseph Pecoraro <joepeck> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, darin, joepeck, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2015-07-01 00:40:49 PDT
What is the elegant way to do this without leaking? Is it this? (id)adoptCF(CGColorCreateGenericGray(...)).get() Created attachment 255908 [details]
[PATCH] Proposed Fix
Seems to work!
Comment on attachment 255908 [details]
[PATCH] Proposed Fix
Woah, good catch. Thankfully never shipped.
Comment on attachment 255908 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255908 Committed r186174: <http://trac.webkit.org/changeset/186174> All reviewed patches have been landed. Closing bug. Comment on attachment 255908 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=255908&action=review > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:640 > + (id)adoptCF(CGColorCreateGenericGray(0, 1.)).get(), Cries out for a helper function. |