Bug 146496

Summary:

Web Inspector: Show suggest popover on Tab press even if it wasn't showing before

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=145885

Attachments:

Description	Flags
Animated GIF of the problem	none
Patch	none

Description Nikita Vasilyev 2015-06-30 23:29:54 PDT

Created attachment 255902 [details]
Animated GIF of the problem

The problem persists in the console and the styles panel.

Steps:

1. Type "window" in the console.
2. Press delete 4 times
3. Press Tab

Expected:
wi|[ndow]

Actual:
wi\t|

| – cursor
[ndow] — suggest text

Comment 1 Radar WebKit Bug Importer 2015-06-30 23:30:25 PDT

<rdar://problem/21627130>

Comment 2 Devin Rousso 2015-07-02 09:16:12 PDT

Created attachment 256013 [details]
Patch

Comment 3 WebKit Commit Bot 2015-07-02 10:32:56 PDT

Comment on attachment 256013 [details]
Patch

Clearing flags on attachment: 256013

Committed r186227: <http://trac.webkit.org/changeset/186227>

Comment 4 WebKit Commit Bot 2015-07-02 10:33:00 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Nikita Vasilyev 2015-07-02 22:35:32 PDT

I should have stressed that this happens not only in the styles sidebar but also in the console (see the steps in the description).

Comment 6 Nikita Vasilyev 2015-07-02 23:45:46 PDT

Just tried ToT WebKit (r186256)—it works as expected in the console too 👍

This patch only changed CSSStyleDeclarationTextEditor.js. Was the console fixed somewhere else?