Summary: | REGRESSION (185319): Reproducible crash in WebHistoryItem launching FluidApp | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, beidson, darin | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2015-06-30 22:35:17 PDT
Created attachment 255899 [details]
Patch v1
Was introduced in http://trac.webkit.org/changeset/185319 Comment on attachment 255899 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=255899&action=review > Source/WebKit/mac/History/WebHistoryItem.mm:363 > NSUInteger size = [redirectURLs count]; After making the thing below a modern Objective-C for loop this can be called right in the reserveInitialCapacity call below. > Source/WebKit/mac/History/WebHistoryItem.mm:365 > + redirectURLsVector->reserveCapacity(size); This should be reserveInitialCapacity. > Source/WebKit/mac/History/WebHistoryItem.mm:368 > for (NSUInteger i = 0; i < size; ++i) { > id redirectURL = [redirectURLs objectAtIndex:i]; This should be a modern Objective-C for loop: for (id redirectURL in redirectURLs) { > Source/WebKit/mac/History/WebHistoryItem.mm:372 > + redirectURLsVector->append((NSString *)redirectURL); This should be uncheckedAppend. |