Bug 146490

Summary:

Web Inspector: Make the first click on a rule section create a newline for easy property addition

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Expected Functionality (from Chrome)	none
Patch	none
After Patch is applied	none
Patch	none

Devin Rousso

Reported 2015-06-30 21:02:52 PDT

Created attachment 255890 [details] Expected Functionality (from Chrome) Clicking on the last line of a rule section should create a newline and place the cursor on the beginning of that newline to make adding new properties easier. This should only happen, however, on the first click of that rule section, meaning that once it is focused (and until it has lost focus) clicking on the last line will simply put the cursor at the end of that line.

Attachments
Expected Functionality (from Chrome) (221.13 KB, video/quicktime) 2015-06-30 21:02 PDT, Devin Rousso	no flags	Details
Patch (3.36 KB, patch) 2015-06-30 21:14 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
After Patch is applied (492.26 KB, video/quicktime) 2015-06-30 21:14 PDT, Devin Rousso	no flags	Details
Patch (6.96 KB, patch) 2015-07-01 11:58 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-06-30 21:03:31 PDT

<rdar://problem/21625881>

Devin Rousso

Comment 2 2015-06-30 21:14:02 PDT

Created attachment 255893 [details] Patch

Devin Rousso

Comment 3 2015-06-30 21:14:30 PDT

Created attachment 255894 [details] After Patch is applied

Timothy Hatcher

Comment 4 2015-06-30 22:13:08 PDT

Comment on attachment 255893 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=255893&action=review > Source/WebInspectorUI/ChangeLog:12 > + (WebInspector.CSSStyleDeclarationTextEditor.prototype._editorFocused): When the editor gains focus and the cursor is on > + the last line of the rule, insert a new line and place the cursor on that line. Chrome seems to do this on any line. Should we? I think last line is fine too.

Devin Rousso

Comment 5 2015-07-01 11:58:14 PDT

Created attachment 255942 [details] Patch

Timothy Hatcher

Comment 6 2015-07-01 16:34:49 PDT

Comment on attachment 255942 [details] Patch Awesome!

WebKit Commit Bot

Comment 7 2015-07-01 17:48:51 PDT

Comment on attachment 255942 [details] Patch Clearing flags on attachment: 255942 Committed r186212: <http://trac.webkit.org/changeset/186212>

WebKit Commit Bot

Comment 8 2015-07-01 17:48:53 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.