Bug 146472

Summary: Web Inspector: ProfileNode cleanup
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-06-30 14:24:25 PDT
* SUMMARY ProfileNode cleanup. Some simple typos and improvements that can be made.
Attachments
[PATCH] Proposed Fix (2.16 KB, patch)
2015-06-30 14:27 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-06-30 14:27:38 PDT
Created attachment 255853 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 2 2015-06-30 15:06:39 PDT
Comment on attachment 255853 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=255853&action=review > Source/WebInspectorUI/UserInterface/Models/ProfileNode.js:210 > - _computeTotalTimes() > + _computeTotalTimesIfNeeded() Whoa!
WebKit Commit Bot
Comment 3 2015-06-30 15:59:02 PDT
Comment on attachment 255853 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255853 Committed r186141: <http://trac.webkit.org/changeset/186141>
WebKit Commit Bot
Comment 4 2015-06-30 15:59:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.