Bug 146459
| Summary: | [Win] Remove LegacyCACFLaterTreeHost Implementation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | Layout and Rendering | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | aroben, bfulgham, simon.fraser, thorton |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
Brent Fulgham
Now that we've moved our target OS to Windows 7, I don't think there is a need to retain the old LegacyCACFLayerTreeHost implementation. This code path is only used for the Apple Windows port, and I don't think there are any active cases where we hit this code anymore.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
CC'ing aroben in case I'm missing something regarding this code.
Adam Roben (:aroben)
Is there some new mechanism being used for accelerated compositing on Windows 7+?
Adam Roben (:aroben)
Oh, I see, WKCACFViewLayerTreeHost is the replacement. The code makes it look like that class is used whenever WebKitQuartzCoreAdditions.dll is present, which seems like it shouldn't be dependent on the version of Windows being run. I think the only consideration is whether you want to support old versions of AAS that don't contain that DLL.
Brent Fulgham
(In reply to comment #3)
> Oh, I see, WKCACFViewLayerTreeHost is the replacement. The code makes it
> look like that class is used whenever WebKitQuartzCoreAdditions.dll is
> present, which seems like it shouldn't be dependent on the version of
> Windows being run. I think the only consideration is whether you want to
> support old versions of AAS that don't contain that DLL.
Yeah -- I don't think there is any such thing (at least, not that we want to be supporting).
So I think it's just dead code at this point.
Brent Fulgham
*** This bug has been marked as a duplicate of bug 147388 ***