| Summary: | REGRESSION: Web Inspector: Jump to Definition is broken | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 255687 [details]
Reduction
Steps:
1. Open click.html
2. Enter "dir({clicked})"
3. Right-click "clicked" and select "Jump to Definition" from the context menu.
Expected:
click.html opens in the debugger or resources tab with the "function clicked() {" line highlighted.
Actual:
Nothing happens.
Should be as easy as making WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject's WebInspector.showSourceCodeLocation(sourceCodeLocation) include the second parameter that forces switching tabs. We get the right location. Created attachment 255765 [details]
[PATCH] Proposed Fix
Comment on attachment 255765 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255765 Committed r186080: <http://trac.webkit.org/changeset/186080> All reviewed patches have been landed. Closing bug. |
Created attachment 255685 [details] Animated GIF of the problem :(