Bug 146376

Summary: REGRESSION: Web Inspector: Jump to Definition is broken
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Animated GIF of the problem
none
Reduction
none
[PATCH] Proposed Fix none

Nikita Vasilyev
Reported 2015-06-26 19:35:41 PDT
Created attachment 255685 [details] Animated GIF of the problem :(
Attachments
Animated GIF of the problem (85.31 KB, image/gif)
2015-06-26 19:35 PDT, Nikita Vasilyev 		no flags
Details
Reduction (69 bytes, text/html)
2015-06-26 19:43 PDT, Nikita Vasilyev 		no flags
Details
[PATCH] Proposed Fix (1.59 KB, patch)
2015-06-29 12:00 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-26 19:36:04 PDT
<rdar://problem/21576867>
Nikita Vasilyev
Comment 2 2015-06-26 19:43:55 PDT
Created attachment 255687 [details] Reduction Steps: 1. Open click.html 2. Enter "dir({clicked})" 3. Right-click "clicked" and select "Jump to Definition" from the context menu. Expected: click.html opens in the debugger or resources tab with the "function clicked() {" line highlighted. Actual: Nothing happens.
Joseph Pecoraro
Comment 3 2015-06-29 10:56:31 PDT
Should be as easy as making WebInspector.ObjectTreeBaseTreeElement.prototype._appendMenusItemsForObject's WebInspector.showSourceCodeLocation(sourceCodeLocation) include the second parameter that forces switching tabs. We get the right location.
Joseph Pecoraro
Comment 4 2015-06-29 12:00:16 PDT
Created attachment 255765 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 5 2015-06-29 12:44:48 PDT
Comment on attachment 255765 [details] [PATCH] Proposed Fix Clearing flags on attachment: 255765 Committed r186080: <http://trac.webkit.org/changeset/186080>
WebKit Commit Bot
Comment 6 2015-06-29 12:44:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.