Bug 146369

Summary: [iOS] Drop buffered data in paused media elements on memory pressure.
Product: WebKit Reporter: Andreas Kling <kling>
Component: MediaAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jeremyj-wk, jer.noble, kling
Priority: P2 Keywords: InRadar, Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146592    
Bug Blocks:    
Attachments:
Description Flags
Patch idea eric.carlson: review+

Andreas Kling
Reported 2015-06-26 16:55:02 PDT
When we get the system memory pressure notification, we should try to drop buffered data for paused media elements. <rdar://problem/20366883>
Attachments
Patch idea (4.91 KB, patch)
2015-06-26 16:55 PDT, Andreas Kling 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2015-06-26 16:55:46 PDT
Created attachment 255675 [details] Patch idea
WebKit Commit Bot
Comment 2 2015-06-26 16:59:32 PDT
Attachment 255675 [details] did not pass style-queue: ERROR: Source/WebCore/platform/MemoryPressureHandler.cpp:148: Missing space around : in range-based for statement [whitespace/colon] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Pratik Solanki
Comment 3 2015-06-26 17:10:16 PDT
*** Bug 146368 has been marked as a duplicate of this bug. ***
Eric Carlson
Comment 4 2015-06-27 07:16:19 PDT
Comment on attachment 255675 [details] Patch idea View in context: https://bugs.webkit.org/attachment.cgi?id=255675&action=review Very nice - thanks! > Source/WebCore/html/HTMLMediaElement.cpp:6385 > +void HTMLMediaElement::dropBufferedDataIfPossible() Nit: "purgeBufferedDataIfPossible" might be slightly clearer.
Andreas Kling
Comment 5 2015-06-28 15:16:57 PDT
Committed r186054: <http://trac.webkit.org/changeset/186054>
Note You need to log in before you can comment on or make changes to this bug.